imback82 commented on a change in pull request #33113:
URL: https://github.com/apache/spark/pull/33113#discussion_r659462276
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -522,66 +552,6 @@ trait CheckAnalysis extends PredicateHelper with
LookupCatalog {
positionArgumentExists(add.position(), parent, fieldsAdded)
TypeUtils.failWithIntervalType(add.dataType())
colsToAdd(parentName) = fieldsAdded :+ add.fieldNames().last
- case update: UpdateColumnType =>
- val field = {
- val f = findField("update", update.fieldNames)
- CharVarcharUtils.getRawType(f.metadata)
- .map(dt => f.copy(dataType = dt))
- .getOrElse(f)
- }
- val fieldName = update.fieldNames.quoted
- update.newDataType match {
- case _: StructType =>
- alter.failAnalysis(s"Cannot update ${table.name} field
$fieldName type: " +
- s"update a struct by updating its fields")
- case _: MapType =>
- alter.failAnalysis(s"Cannot update ${table.name} field
$fieldName type: " +
- s"update a map by updating $fieldName.key or
$fieldName.value")
- case _: ArrayType =>
- alter.failAnalysis(s"Cannot update ${table.name} field
$fieldName type: " +
- s"update the element by updating $fieldName.element")
- case u: UserDefinedType[_] =>
- alter.failAnalysis(s"Cannot update ${table.name} field
$fieldName type: " +
- s"update a UserDefinedType[${u.sql}] by updating its
fields")
- case _: CalendarIntervalType | _: YearMonthIntervalType |
- _: DayTimeIntervalType =>
- alter.failAnalysis(s"Cannot update ${table.name} field
$fieldName to " +
- s"interval type")
- case _ =>
- // update is okay
- }
-
- // We don't need to handle nested types here which shall fail
before
Review comment:
These changes are moved below to `checkAlterTableCommand`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
