xkrogen opened a new pull request #33116:
URL: https://github.com/apache/spark/pull/33116
### What changes were proposed in this pull request?
`ExternalBlockHandler` exposes 4 metrics which are Dropwizard `Timer`
metrics, and are named with a `millis` suffix:
```
private final Timer openBlockRequestLatencyMillis = new Timer();
private final Timer registerExecutorRequestLatencyMillis = new Timer();
private final Timer fetchMergedBlocksMetaLatencyMillis = new Timer();
private final Timer finalizeShuffleMergeLatencyMillis = new Timer();
```
However these Dropwizard Timers by default use nanoseconds
([documentation](https://metrics.dropwizard.io/3.2.3/getting-started.html#timers)).
It's certainly possible to extract milliseconds from them, but it seems
misleading to have millis in the name here.
This causes `YarnShuffleServiceMetrics` to expose confusingly-named metrics
like `openBlockRequestLatencyMillis_count` and
`openBlockRequestLatencyMillis_nanos` (the actual values are in nanos). It
should be up to the metrics exporter, like `YarnShuffleServiceMetrics`, to
decide the unit and adjust the name accordingly, so the unit shouldn't be
included in the name of the metric itself.
This PR proposes to remove the 'millis' suffix from these metrics.
### Does this PR introduce _any_ user-facing change?
Yes, the name of these four metrics will no longer include "millis" as a
suffix.
### How was this patch tested?
Unit tests have been updated. Changes are a trivial find-and-replace rename.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
