sarutak opened a new pull request #33121:
URL: https://github.com/apache/spark/pull/33121
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR changes `SparkBuild.scala` to edit `config.properties` in `yarn`
sub-module in build with SBT like as build with Maven does.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
yarn sub-module contains config.properties.
```
spark.yarn.isHadoopProvided = ${spark.yarn.isHadoopProvided}
```
The `${spark.yarn.isHadoopProvided}` part is replaced with `true` or `false`
in build depending on whether Hadoop is provided or not (specified by
-Phadoop-provided).
The edited config.properties will be loaded at runtime to control how to
populate Hadoop-related classpath.
If we build with Maven, these process works but doesn't with SBT.
If we build with SBT and deploy apps on YARN, the following warning appears
and classpath is not populated correctly.
```
21/06/29 10:51:20 WARN config.package: Can not load the default value of
`spark.yarn.isHadoopProvided` from
`org/apache/spark/deploy/yarn/config.properties` with error,
java.lang.IllegalArgumentException: For input string:
"${spark.yarn.isHadoopProvided}". Using `false` as a default value.
```
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
Built with SBT and extracted `config.properties` from the build artifact and
confirmed `${spark.yarn.isHadoopProvided} was correctly edited with `true` or
`false`.
```
cat org/apache/spark/deploy/yarn/config.properties
spark.yarn.isHadoopProvided = false # In case
build with -Pyarn and without -Phadoop-provided
spark.yarn.isHadoopProvided = true # In case
build with -Pyarn and -Phadoop-provided
```
I also confirmed the warning message shown above no longer appears.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
