cloud-fan commented on pull request #32365: URL: https://github.com/apache/spark/pull/32365#issuecomment-870230165
> If we want to switch to Hive format strings we should add a configuration and apply to Cast, result strings, and everywhere without adding a new API like toPrettyString. No, we don't want to follow Hive completely. We just want to be internally consistent for printing the result, e.g. `df.show`. We want to follow `spark-sql` shell which happens to follow Hive. We need a new expression and only apply it when printing the query result. BTW why do we add a new API in `Column`? I think the only exception is TRANSFORM, where we must follow Hive, and using `ToPrettyString` does not guarantee it because its semantic is just a way to print the query result. Maybe we should name it `ToHiveString` to make it clear, and explain why do we follow Hive to print result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
