dongjoon-hyun commented on a change in pull request #33125:
URL: https://github.com/apache/spark/pull/33125#discussion_r660296765



##########
File path: dev/sparktestsupport/modules.py
##########
@@ -769,7 +769,7 @@ def __hash__(self):
 
 docker_integration_tests = Module(
     name="docker-integration-tests",
-    dependencies=[],
+    dependencies=[sql],

Review comment:
       Got it. In that case, shall we move that part from here to `sql` module?

##########
File path: dev/sparktestsupport/modules.py
##########
@@ -769,7 +769,7 @@ def __hash__(self):
 
 docker_integration_tests = Module(
     name="docker-integration-tests",
-    dependencies=[],
+    dependencies=[sql],

Review comment:
       Got it.

##########
File path: dev/sparktestsupport/modules.py
##########
@@ -769,7 +769,7 @@ def __hash__(self):
 
 docker_integration_tests = Module(
     name="docker-integration-tests",
-    dependencies=[],
+    dependencies=[sql],

Review comment:
       Then, it will happen at `catalyst` module change, too. I'll put it to 
both `catalyst` and `sql` module.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to