cloud-fan commented on a change in pull request #33123:
URL: https://github.com/apache/spark/pull/33123#discussion_r660656779
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/ShufflePartitionsUtil.scala
##########
@@ -172,7 +172,7 @@ object ShufflePartitionsUtil extends Logging {
// coalesce any partitions after the end of last skew section.
if (numPartitions > start) {
val partitionSpecs = coalescePartitions(
- partitionIndices(start), partitionIndices.last + 1, validMetrics,
targetSize)
+ partitionIndices(start), partitionIndices.last + 1, validMetrics,
targetSize, true)
newPartitionSpecsSeq.zip(partitionSpecs).foreach(spec => spec._1 ++=
spec._2)
}
Review comment:
How do we make sure we return at least one partition spec if there is no
skew partition spec?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
