mridulm commented on a change in pull request #33078:
URL: https://github.com/apache/spark/pull/33078#discussion_r661062558
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/PushBlockStream.java
##########
@@ -99,10 +110,11 @@ public void encode(ByteBuf buf) {
public static PushBlockStream decode(ByteBuf buf) {
String appId = Encoders.Strings.decode(buf);
+ int attemptId = buf.readInt();
Review comment:
Technically, this is a breaking change, since it was introduced in 3.1
But given it cant be used until push based shuffle can be enabled, this
should be fine.
Thoughts @Ngone51 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
