cxzl25 commented on a change in pull request #33114:
URL: https://github.com/apache/spark/pull/33114#discussion_r661123735
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
##########
@@ -925,19 +925,19 @@ private[hive] class HiveClientImpl(
}
override def createFunction(db: String, func: CatalogFunction): Unit =
withHiveState {
- shim.createFunction(client, db, func)
+ shim.createFunction(client, db, func, userName)
}
override def dropFunction(db: String, name: String): Unit = withHiveState {
shim.dropFunction(client, db, name)
}
override def renameFunction(db: String, oldName: String, newName: String):
Unit = withHiveState {
- shim.renameFunction(client, db, oldName, newName)
+ shim.renameFunction(client, db, oldName, newName, userName)
}
override def alterFunction(db: String, func: CatalogFunction): Unit =
withHiveState {
- shim.alterFunction(client, db, func)
+ shim.alterFunction(client, db, func, userName)
Review comment:
`renameFunction` can keep the original owner name, and the function
definition has been modified except for the function name of `alterFunction`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
