Ngone51 commented on a change in pull request #33101:
URL: https://github.com/apache/spark/pull/33101#discussion_r661245031
##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -285,13 +285,10 @@ private[spark] object Utils extends Logging {
*/
def createDirectory(dir: File): Boolean = {
try {
- // This sporadically fails - not sure why ... !dir.exists() &&
!dir.mkdirs()
- // So attempting to create and then check if directory was created or
not.
- dir.mkdirs()
- if ( !dir.exists() || !dir.isDirectory) {
- logError(s"Failed to create directory " + dir)
- }
- dir.isDirectory
+ // SPARK-35907
+ // This could throw more meaningful exception information if directory
creation failed.
+ Files.createDirectories(dir.toPath)
+ true
Review comment:
Hm..this looks like a behavior change to me. Are you sure
`Files.createDirectories` would always not fail silently?
Otherwise, I'd prefer to keep:
```scala
if ( !dir.exists() || !dir.isDirectory) {
logError(s"Failed to create directory " + dir)
}
dir.isDirectory
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
