linhongliu-db commented on a change in pull request #32832:
URL: https://github.com/apache/spark/pull/32832#discussion_r661660462
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -424,6 +424,12 @@ class Analyzer(override val catalogManager: CatalogManager)
*/
object ResolveAliases extends Rule[LogicalPlan] {
private def assignAliases(exprs: Seq[NamedExpression]) = {
+ def extractOnly(e: Expression): Boolean = e match {
+ case _: ExtractValue => e.children.forall(extractOnly)
+ case _: Literal => true
Review comment:
@cloud-fan I don't think the alias of literal will be changed. And in
order to keep current test cases passing. I prefer allowing the literal for non
ExtractValue as well. Is this OK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
