sunchao commented on a change in pull request #32753:
URL: https://github.com/apache/spark/pull/32753#discussion_r661709891
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/ParquetVectorUpdater.java
##########
@@ -30,20 +30,28 @@
* @param values destination values vector
* @param valuesReader reader to read values from
*/
- void updateBatch(
+ void readValues(
int total,
int offset,
WritableColumnVector values,
VectorizedValuesReader valuesReader);
+ /**
+ * Skip a batch of `total` values from `valuesReader`.
+ *
+ * @param total total number of values to skip
+ * @param valuesReader reader to skip values from
+ */
+ void skipValues(int total, VectorizedValuesReader valuesReader);
Review comment:
Updated the PR description. Regarding the comment, IMO even though the
method name is changed, the comment is still accurate in expressing what the
method does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
