aokolnychyi commented on a change in pull request #33008: URL: https://github.com/apache/spark/pull/33008#discussion_r661753646
########## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/SupportsRowLevelOperations.java ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connector.catalog; + +import org.apache.spark.annotation.Experimental; +import org.apache.spark.sql.connector.write.LogicalWriteInfo; +import org.apache.spark.sql.connector.write.RowLevelOperation.Command; +import org.apache.spark.sql.connector.write.RowLevelOperationBuilder; +import org.apache.spark.sql.connector.write.RowLevelOperation; + +/** + * A mix-in interface for {@link Table} row-level operations support. Data sources can implement + * this interface to indicate they support rewriting data for DELETE, UPDATE, MERGE operations. + * + * @since 3.2.0 + */ +@Experimental +public interface SupportsRowLevelOperations extends Table { + /** + * Returns a {@link RowLevelOperationBuilder} to build a {@link RowLevelOperation}. + * Spark will call this method while planning DELETE, UPDATE or MERGE operations. + * + * @param command the row-level operation command (e.g. DELETE, UPDATE, MERGE) + * @param info write info + * @return the row-level operation builder + */ + RowLevelOperationBuilder newRowLevelOperationBuilder(Command command, LogicalWriteInfo info); Review comment: We should probably pass options instead of the write info here so that we can propagate user config. Then we can pass `LogicalWriteInfo` to `writeBuilder` in `RowLevelOperation` and that write info will have a correct write schema. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
