otterc commented on a change in pull request #33034:
URL: https://github.com/apache/spark/pull/33034#discussion_r661811779
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/AbstractFetchShuffleBlocks.java
##########
@@ -33,21 +33,25 @@
public final String appId;
public final String execId;
public final int shuffleId;
+ public final int shuffleSequenceId;
protected AbstractFetchShuffleBlocks(
String appId,
String execId,
- int shuffleId) {
+ int shuffleId,
+ int shuffleSequenceId) {
Review comment:
This is backward incompatible change. It changes the
`FetchShuffleBlocks` message
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/FetchShuffleBlocks.java
##########
@@ -42,10 +42,11 @@ public FetchShuffleBlocks(
String appId,
String execId,
int shuffleId,
+ int shuffleSequenceId,
Review comment:
All the changes in this class are backward incompatible. You just need
to `FetchShuffleBlockChunks`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
