cloud-fan commented on a change in pull request #33142:
URL: https://github.com/apache/spark/pull/33142#discussion_r661939832



##########
File path: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SubexpressionEliminationSuite.scala
##########
@@ -47,46 +47,43 @@ class SubexpressionEliminationSuite extends SparkFunSuite 
with ExpressionEvalHel
 

Review comment:
       The changes in this file is to adapt the new API in 
`EquivalentExpressions`. e.g.
   `getAllEquivalentExprs()` -> `getAllExprStates`
   `getEquivalentExprs(oneA).size == 1` -> `getExprState(oneA).get.useCount == 
1`
   `getEquivalentExprs(oneA).exists(_ eq oneA)` -> 
`getExprState(oneA).exists(_.expr eq oneA)`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to