cloud-fan commented on a change in pull request #33164:
URL: https://github.com/apache/spark/pull/33164#discussion_r661947165
##########
File path: core/src/test/java/org/apache/spark/SparkThrowableSuite.java
##########
@@ -0,0 +1,150 @@
+package org.apache.spark;
+
+import java.io.*;
+import java.nio.charset.Charset;
+import java.util.Map;
+import java.util.HashSet;
+import java.util.IllegalFormatException;
+import java.util.SortedMap;
+
+import com.fasterxml.jackson.core.JsonParser.Feature;
+import com.fasterxml.jackson.core.type.TypeReference;
+import com.fasterxml.jackson.databind.SerializationFeature;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.json.JsonMapper;
+import org.apache.commons.io.IOUtils;
+import org.junit.Assert;
+import org.junit.Test;
+
+import org.apache.spark.SparkThrowable.SparkThrowableHelper;
+
+public class SparkThrowableSuite implements Serializable {
Review comment:
I think the test in Scala is good enough, which also covers the most
common case: we usualy extend `SparkThrowable` in the scala code (spark
codebase is mostly scala).
##########
File path: core/src/test/java/org/apache/spark/SparkThrowableSuite.java
##########
@@ -0,0 +1,150 @@
+package org.apache.spark;
+
+import java.io.*;
+import java.nio.charset.Charset;
+import java.util.Map;
+import java.util.HashSet;
+import java.util.IllegalFormatException;
+import java.util.SortedMap;
+
+import com.fasterxml.jackson.core.JsonParser.Feature;
+import com.fasterxml.jackson.core.type.TypeReference;
+import com.fasterxml.jackson.databind.SerializationFeature;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.json.JsonMapper;
+import org.apache.commons.io.IOUtils;
+import org.junit.Assert;
+import org.junit.Test;
+
+import org.apache.spark.SparkThrowable.SparkThrowableHelper;
+
+public class SparkThrowableSuite implements Serializable {
Review comment:
I think the test in Scala is good enough, which also covers the most
common case: we usually extend `SparkThrowable` in the scala code (spark
codebase is mostly scala).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
