MaxGekk commented on a change in pull request #33176:
URL: https://github.com/apache/spark/pull/33176#discussion_r662430089
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2820,6 +2821,23 @@ object SQLConf {
.booleanConf
.createWithDefault(true)
+ object TimestampTypes extends Enumeration {
+ val TIMESTAMP_NTZ, TIMESTAMP_LTZ = Value
+ }
+
+ val TIMESTAMP_TYPE =
+ buildConf("spark.sql.timestampType")
+ .doc("Configures the default timestamp type of Spark SQL, including SQL
DDL and Cast " +
+ "clause. Setting the configuration as TIMESTAMP_NTZ will use TIMESTAMP
WITHOUT TIME " +
Review comment:
Can't you get the name from enum as you did that in
`.createWithDefault(TimestampTypes.TIMESTAMP_LTZ.toString)`. Maybe we will
rename it again soon, who knows ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
