Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4450#discussion_r29561207
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockObjectWriter.scala ---
@@ -54,9 +54,14 @@ private[spark] abstract class BlockObjectWriter(val
blockId: BlockId) {
def revertPartialWritesAndClose()
/**
- * Writes an object.
+ * Writes a key-value pair.
*/
- def write(value: Any)
+ def write(key: Any, value: Any)
+
+ /**
+ * Notify the writer that a record worth of bytes has been written with
writeBytes.
--- End diff --
I think this comment is out of date; there isn't a `writeBytes` method in
the general `BlockObjectWriter` interface, only in `DiskBlockObjectWriter`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
