cloud-fan commented on a change in pull request #32959:
URL: https://github.com/apache/spark/pull/32959#discussion_r662805329
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -269,10 +274,6 @@ object DateTimeUtils {
i += 3
} else if (i < 2) {
if (b == '-') {
- if (i == 0 && j != 4) {
- // year should have exact four digits
Review comment:
Again, shall we check the number of year digits? what if overflow
happens? like `999999999999999999-12-12`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
