ulysses-you commented on a change in pull request #33188:
URL: https://github.com/apache/spark/pull/33188#discussion_r662979360
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala
##########
@@ -250,7 +250,10 @@ object EnsureRequirements extends Rule[SparkPlan] {
def apply(plan: SparkPlan): SparkPlan = plan.transformUp {
// TODO: remove this after we create a physical operator for
`RepartitionByExpression`.
- case operator @ ShuffleExchangeExec(upper: HashPartitioning, child, _) =>
+ // SPARK-35989: AQE will change the partition number so we should retain
the REPARTITION_BY_NUM
+ // shuffle which is specified by user.
+ case operator @ ShuffleExchangeExec(upper: HashPartitioning, child,
shuffleOrigin)
+ if !(shuffleOrigin == REPARTITION_BY_NUM &&
conf.adaptiveExecutionEnabled) =>
Review comment:
make sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
