zhouyejoe commented on a change in pull request #33078:
URL: https://github.com/apache/spark/pull/33078#discussion_r663662561
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -2225,4 +2225,14 @@ package object config {
.stringConf
.toSequence
.createWithDefault(Nil)
+
+ private[spark] val APP_ATTEMPT_ID =
+ ConfigBuilder("spark.app.attempt.id")
Review comment:
Should we use "String" or "Integer" here for this configuration? In
[SparkContext where it gets the Application
AttemptID](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/SparkContext.scala#L340),
it is a String format. But when parsing into Configuration and also resolving
this in RemoteBlockPushResolver, we are using Integer to determine whether it
is a new attempt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
