MaxGekk commented on a change in pull request #33217:
URL: https://github.com/apache/spark/pull/33217#discussion_r664334657



##########
File path: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuiteBase.scala
##########
@@ -1267,7 +1280,12 @@ abstract class CastSuiteBase extends SparkFunSuite with 
ExpressionEvalHelper {
           val e = intercept[IllegalArgumentException] {
             cast(Literal.create(interval), dataType).eval()
           }.getMessage
-          assert(e.contains("Interval string does not match day-time format"))
+          assert(e.contains(s"Interval string does not match day-time format 
of " +
+            s"${IntervalUtils.supportedFormat((dataType.startField, 
dataType.endField))
+              .map(format => s"`$format`").mkString(", ")} " +
+            s"when cast to ${dataType.typeName}: $interval, " +
+            s"set spark.sql.legacy.fromDayTimeString.enabled to true " +

Review comment:
       Please, replace it by `LEGACY_FROM_DAYTIME_STRING.key`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to