Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5820#discussion_r29567541
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/Evaluator.scala ---
    @@ -36,5 +35,18 @@ abstract class Evaluator extends Identifiable {
        * @param paramMap parameter map that specifies the input columns and 
output metrics
        * @return metric
        */
    -  def evaluate(dataset: DataFrame, paramMap: ParamMap): Double
    +  def evaluate(dataset: DataFrame, paramMap: ParamMap): Double = {
    +    this.copy(paramMap).evaluate(dataset)
    +  }
    +
    --- End diff --
    
    `Evaluator` is used for tuning model, where we need a scalar metric to 
select the best model. We can try returning a comparable `T`, but this is not 
part of this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to