srowen commented on a change in pull request #31948:
URL: https://github.com/apache/spark/pull/31948#discussion_r663914637
##########
File path: core/src/main/scala/org/apache/spark/status/api/v1/api.scala
##########
@@ -342,6 +342,7 @@ class ShuffleWriteMetrics private[spark](
class TaskMetricDistributions private[spark](
val quantiles: IndexedSeq[Double],
+ val duration: IndexedSeq[Double],
Review comment:
I think this one is fine, but a brief recap: Mima tries to detect
changes to public APIs, which could cause binary or source incompatibilities,
and we generally never allow those in minor releases. This method signature
change triggers Mima, although it's actually 'private'; because it's private to
a package, it's technically public in the bytecode, and Mima doesn't know it
was private[spark] in Scala. So that's fine, it should be 'excluded' in Mima.
The reason this never failed the tests originally was because this method
was already excluded, because it changed from 3.0 to 3.1 too. The way Mima was
set up, we were reusing exclusions from 3.0 to 3.1 when evaluating changes from
3.1 to 3.2 as well. That could be a problem, if the change from 3.1 to 3.2 was
not intended. When we fixed the Mima config, this method popped up as possibly
accidentally excluded, so Dongjoon was double-checking.
I think the ones he found are actually OK, just checking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
