ueshin commented on a change in pull request #33223:
URL: https://github.com/apache/spark/pull/33223#discussion_r664782457
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -366,9 +366,7 @@ jobs:
# See also https://github.com/sphinx-doc/sphinx/issues/7551.
# Jinja2 3.0.0+ causes error when building with Sphinx.
# See also https://issues.apache.org/jira/browse/SPARK-35375.
- # TODO(SPARK-35684, SPARK-35683): Bump up the mypy version. This is
blocked by
- # Index.difference logic issue.
- python3.6 -m pip install flake8 pydata_sphinx_theme 'mypy==0.812'
numpydoc 'jinja2<3.0.0' 'black==21.5b2'
+ python3.6 -m pip install flake8 pydata_sphinx_theme 'mypy==0.910'
numpydoc 'jinja2<3.0.0' 'black==21.5b2' types-tabulate
Review comment:
I'd rather add the `tabulate` entry in `mypy.ini`.
```
[mypy-tabulate.*]
ignore_missing_imports = True
```
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -366,9 +366,7 @@ jobs:
# See also https://github.com/sphinx-doc/sphinx/issues/7551.
# Jinja2 3.0.0+ causes error when building with Sphinx.
# See also https://issues.apache.org/jira/browse/SPARK-35375.
- # TODO(SPARK-35684, SPARK-35683): Bump up the mypy version. This is
blocked by
- # Index.difference logic issue.
- python3.6 -m pip install flake8 pydata_sphinx_theme 'mypy==0.812'
numpydoc 'jinja2<3.0.0' 'black==21.5b2'
+ python3.6 -m pip install flake8 pydata_sphinx_theme 'mypy==0.910'
numpydoc 'jinja2<3.0.0' 'black==21.5b2' types-tabulate
Review comment:
Or we should install other libraries and remove the entries in
`mypy.ini` (in the future)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
