viirya commented on a change in pull request #33214:
URL: https://github.com/apache/spark/pull/33214#discussion_r664970252
##########
File path: python/pyspark/sql/types.py
##########
@@ -1020,14 +1020,22 @@ def _infer_type(obj):
return dataType()
if isinstance(obj, dict):
- for key, value in obj.items():
- if key is not None and value is not None:
- return MapType(_infer_type(key), _infer_type(value), True)
- return MapType(NullType(), NullType(), True)
+ if infer_dict_as_struct:
+ struct = StructType()
+ for key, value in obj.items():
+ if key is not None and value is not None:
+ struct.add(key, _infer_type(value, infer_dict_as_struct),
True)
+ return struct
+ else:
+ for key, value in obj.items():
+ if key is not None and value is not None:
+ return MapType(_infer_type(key, infer_dict_as_struct),
+ _infer_type(value, infer_dict_as_struct),
True)
+ return MapType(NullType(), NullType(), True)
Review comment:
Do we need to log warning if inferred value types are not inconsistent?
We can recommend users to use the config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
