viirya commented on a change in pull request #33187: URL: https://github.com/apache/spark/pull/33187#discussion_r665946791
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala ########## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.streaming.state + +import java.io._ + +import org.apache.hadoop.conf.Configuration + +import org.apache.spark.{SparkConf, SparkEnv} +import org.apache.spark.internal.Logging +import org.apache.spark.sql.catalyst.expressions.UnsafeRow +import org.apache.spark.sql.types.StructType +import org.apache.spark.unsafe.Platform +import org.apache.spark.util.Utils + +private[state] class RocksDBStateStoreProvider + extends StateStoreProvider with Logging with Closeable { + import RocksDBStateStoreProvider._ + + class RocksDBStateStore(lastVersion: Long) extends StateStore { + /** Trait and classes representing the internal state of the store */ + trait STATE + case object UPDATING extends STATE + case object COMMITTED extends STATE + case object ABORTED extends STATE + + @volatile private var state: STATE = UPDATING + @volatile private var isValidated = false + + override def id: StateStoreId = RocksDBStateStoreProvider.this.stateStoreId + + override def version: Long = lastVersion Review comment: I recommend to be consistent with `HDFSBackedStateStore` where it uses `version` and `newVersion`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
