Ngone51 commented on a change in pull request #33251:
URL: https://github.com/apache/spark/pull/33251#discussion_r666222446
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/SimpleDownloadFile.java
##########
@@ -46,8 +46,9 @@ public SimpleDownloadFile(File file, TransportConf
transportConf) {
}
@Override
- public boolean delete() {
- return file.delete();
Review comment:
Do you mean the original implementation has the reference to
`DownloadFile` instance itself? `DownloadFile` -> `file`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
