Github user TanninOne commented on the pull request:
https://github.com/apache/spark/pull/5811#issuecomment-98631167
Has anyone verified that a **string** comparison against -1 completely
fully fixes the issue? Isn't it interpreted as an integer later?
What I'm getting at is: What if the user has the variable to "-01". or to
"-2"? Maybe those were valid values for mapred.reduce.tasks as well? How was
zero handled in hadoop?
Wouldn't it be safer and cleaner to test any variable against a valid range?
I.e. "if (Integer.parseInt("value") < 1) ..."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
