Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5842#discussion_r29572509
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/stat/StatFunctions.scala
---
@@ -95,4 +97,28 @@ private[sql] object StatFunctions {
val counts = collectStatisticalData(df, cols)
counts.cov
}
+
+ /** Generate a table of frequencies for the elements of two columns. */
+ private[sql] def crossTabulate(df: DataFrame, col1: String, col2:
String): DataFrame = {
+ val tableName = s"${col1}_$col2"
--- End diff --
In my previous comment, I mean this `tableName` is not document. Users need
to know the name of the first column to operate.
minor: It would be good to check pandas' OR R's naming for this column and
follow one of them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
