sarutak commented on pull request #33276: URL: https://github.com/apache/spark/pull/33276#issuecomment-877258226
> is it really safe to be mixing profiles this way? Unless any profile in a pom is specified explicitly, profiles tagged as `activeByDefault` in the pom should be activated. `yarn/pom.xml` contains two profiles (`hadoop-2.7` and `hadoop-3.2`) so unless building with `-Phadoop-2.7`, I think this should work. In other words, `hadoop-3.2` is still activated even if any profiles absent in `yarn/pom.xml` (e.g. -Phive -Phive-thriftserver) are explicitly activated. https://maven.apache.org/ref/3.3.9/maven-model/apidocs/org/apache/maven/model/Activation.html#setActiveByDefault(boolean) > it might be simplest just to put bouncy castle on the test CP always. I tried this way and seems to work. @HyukjinKwon , @sunchao what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
