Yikun commented on a change in pull request #33270:
URL: https://github.com/apache/spark/pull/33270#discussion_r667095363
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -284,6 +284,24 @@ private[spark] object Config extends Logging {
.toSequence
.createWithDefault(Nil)
+ val KUBERNETES_EXECUTOR_POD_DECOMMISSION_LABEL =
Review comment:
doc updating for new config: `docs/running-on-kubernetes.md`.
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -284,6 +284,24 @@ private[spark] object Config extends Logging {
.toSequence
.createWithDefault(Nil)
+ val KUBERNETES_EXECUTOR_POD_DECOMMISSION_LABEL =
+ ConfigBuilder("spark.kubernetes.executor.pod.decommmissionLabel")
+ .doc("Label to apply to a pod which is being decommissioned." +
+ " Designed for use with pod disruption budgets and similar mechanism "
+
Review comment:
nit: redundant space in line end.
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -284,6 +284,24 @@ private[spark] object Config extends Logging {
.toSequence
.createWithDefault(Nil)
+ val KUBERNETES_EXECUTOR_POD_DECOMMISSION_LABEL =
+ ConfigBuilder("spark.kubernetes.executor.pod.decommmissionLabel")
+ .doc("Label to apply to a pod which is being decommissioned." +
+ " Designed for use with pod disruption budgets and similar mechanism "
+
+ " such as pod-deletion-cost.")
+ .version("3.2.0")
+ .stringConf
+ .createOptional
+
+ val KUBERNETES_EXECUTOR_POD_DECOMMISSION_LABEL_VALUE =
+ ConfigBuilder("spark.kubernetes.executor.pod.decommmissionLabelValue")
+ .doc("Label value to apply to a pod which is being decommissioned." +
+ " Designed for use with pod disruption budgets and similar mechanism "
+
Review comment:
ditto, redundant space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
