srowen commented on a change in pull request #33251:
URL: https://github.com/apache/spark/pull/33251#discussion_r667219025
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/DownloadFile.java
##########
@@ -26,22 +26,14 @@
* which ensures data is not read until after the writer is closed.
*/
public interface DownloadFile {
- /**
- * Delete the file.
- *
- * @return <code>true</code> if and only if the file or directory is
Review comment:
I think that's probably OK - will likely trigger a MiMa error that will
need to be excluded. Nobody should be implementing this interface outside Spark.
##########
File path: common/network-common/pom.xml
##########
@@ -22,7 +22,7 @@
<parent>
<groupId>org.apache.spark</groupId>
<artifactId>spark-parent_2.12</artifactId>
- <version>3.3.0-SNAPSHOT</version>
+ <version>spark-755999</version>
Review comment:
Is this necessary for testing? obv. just need to revert at some point.
Not sure what the build will do with this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
