srowen commented on a change in pull request #33287:
URL: https://github.com/apache/spark/pull/33287#discussion_r667335982
##########
File path:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
##########
@@ -574,14 +574,14 @@ public UTF8String trim() {
public UTF8String trimAll() {
int s = 0;
// skip all of the whitespaces (<=0x20) in the left side
- while (s < this.numBytes && Character.isWhitespace(getByte(s))) s++;
+ while (s < this.numBytes && getByte(s) <= 0x20) s++;
Review comment:
Is either behavior more 'correct'? I'm not sure what this is trying to
match. It's possible `.isWhitespace` is a better behavior, in which case the
docs should change. By default I'd not change behavior unless there's a reason
it's not intended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
