gengliangwang commented on a change in pull request #33280:
URL: https://github.com/apache/spark/pull/33280#discussion_r667428474
##########
File path:
sql/core/src/test/resources/sql-tests/results/timestampNTZ/datetime.sql.out
##########
@@ -146,7 +146,7 @@ NULL 2016-12-31 2016-12-31
-- !query
select to_timestamp(null), to_timestamp('2016-12-31 00:12:00'),
to_timestamp('2016-12-31', 'yyyy-MM-dd')
-- !query schema
-struct<to_timestamp(NULL):timestamp,to_timestamp(2016-12-31
00:12:00):timestamp,to_timestamp(2016-12-31, yyyy-MM-dd):timestamp>
+struct<to_timestamp(NULL):timestamp_ntz,to_timestamp(2016-12-31
00:12:00):timestamp_ntz,to_timestamp(2016-12-31, yyyy-MM-dd):timestamp_ntz>
Review comment:
updated
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1931,16 +1932,16 @@ case class ParseToTimestamp(left: Expression, format:
Option[Expression], child:
extends RuntimeReplaceable {
def this(left: Expression, format: Expression) = {
- this(left, Option(format), GetTimestamp(left, format))
+ this(left, Option(format), GetTimestamp(left, format,
SQLConf.get.timestampType))
}
- def this(left: Expression) = this(left, None, Cast(left, TimestampType))
+ def this(left: Expression) = this(left, None, Cast(left,
SQLConf.get.timestampType))
override def flatArguments: Iterator[Any] = Iterator(left, format)
override def exprsReplaced: Seq[Expression] = left +: format.toSeq
override def prettyName: String = "to_timestamp"
- override def dataType: DataType = TimestampType
+ override val dataType: DataType = SQLConf.get.timestampType
Review comment:
Updated
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1008,17 +1008,17 @@ case class UnixTimestamp(
copy(timeExp = newLeft, format = newRight)
}
-case class GetTimestampNTZ(
+/**
+ * Gets timestamps from strings using given pattern.
Review comment:
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
