MaxGekk commented on a change in pull request #33280:
URL: https://github.com/apache/spark/pull/33280#discussion_r667515681
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1008,17 +1008,17 @@ case class UnixTimestamp(
copy(timeExp = newLeft, format = newRight)
}
-case class GetTimestampNTZ(
+/**
+ * Gets timestamps or dates from strings.
Review comment:
I mean that:
1. GetTimestamp doesn't override `inputTypes()`. It mean it inherits
implementation from its parent `ToTimestamp`
2. `ToTimestamp` has the following implementation:
```scala
override def inputTypes: Seq[AbstractDataType] =
Seq(TypeCollection(StringType, DateType, TimestampType), StringType)
```
It means the first argument can be a timestamp or a date, or a string but
not only a string as you say in the comment. And it doesn't return a date only
timestamp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
