MaxGekk commented on a change in pull request #33278:
URL: https://github.com/apache/spark/pull/33278#discussion_r667516368
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1091,8 +1091,13 @@ abstract class ToTimestamp
override protected def formatString: Expression = right
override protected def isParsing = true
+ override def forTimestampNTZ: Boolean = left.dataType match {
+ case TimestampNTZType => true
+ case _ => false
+ }
+
Review comment:
@beliefer Could you re-trigger GAs since they have more tests than
jenkins build. And the method can be rewritten in simpler way I guess:
```scala
override val forTimestampNTZ: Boolean = left.dataType == TimestampNTZType
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
