dgd-contributor commented on a change in pull request #33291:
URL: https://github.com/apache/spark/pull/33291#discussion_r667689380
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala
##########
@@ -351,10 +351,24 @@ object PartitioningUtils {
*/
def getPathFragment(spec: TablePartitionSpec, partitionSchema: StructType):
String = {
Review comment:
> Can we use the same code path with the one when it's non-empty?
I think no. The below code separate code path for update partition metadata
of updated partition (non-empty) and empty
https://github.com/apache/spark/blob/badb0393d46d7aef90710e51e233fb5077977423/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala#L189-L198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
