gengliangwang commented on a change in pull request #33299:
URL: https://github.com/apache/spark/pull/33299#discussion_r668107169
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##########
@@ -552,6 +552,8 @@ object FunctionRegistry {
expression[TimeWindow]("window"),
expression[MakeDate]("make_date"),
expression[MakeTimestamp]("make_timestamp"),
+ expression[MakeTimestampNTZ]("make_timestamp_ntz", true),
Review comment:
It means we don't need to override the `prettyName` method.
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -2284,6 +2284,128 @@ case class MakeDate(
copy(year = newFirst, month = newSecond, day = newThird)
}
+// scalastyle:off line.size.limit
+@ExpressionDescription(
+ usage = "_FUNC_(year, month, day, hour, min, sec[, timezone]) - Create local
date-time from year, month, day, hour, min, sec and timezone fields. ",
Review comment:
Updated. Sorry about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
