cloud-fan commented on a change in pull request #33200:
URL: https://github.com/apache/spark/pull/33200#discussion_r667995696
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statements.scala
##########
@@ -229,22 +228,13 @@ case class ReplaceTableAsSelectStatement(
* Column data as parsed by ALTER TABLE ... ADD COLUMNS.
*/
case class QualifiedColType(
- name: Seq[String],
+ fieldName: FieldName,
Review comment:
I'm not very sure about this change. This is the column to add and we
don't need to resolve the field name, right?
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -1101,19 +1068,80 @@ case class UnsetTableProperties(
trait AlterTableCommand extends UnaryCommand {
Review comment:
I think this is `AlterTableColumnCommand`? For example, ALTER TABLE ...
SET TBLPROPERTY does not use it.
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statements.scala
##########
@@ -229,22 +228,13 @@ case class ReplaceTableAsSelectStatement(
* Column data as parsed by ALTER TABLE ... ADD COLUMNS.
*/
case class QualifiedColType(
- name: Seq[String],
+ fieldName: FieldName,
Review comment:
can you summarize what we need to do for it? What I can think of:
1. normalize the field name according to the actual table schema
2. make sure the column name does not exist in the table schema
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
