HyukjinKwon commented on a change in pull request #33293:
URL: https://github.com/apache/spark/pull/33293#discussion_r668394064
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -344,29 +344,28 @@ object DateTimeUtils {
segments(6) /= 10
digitsMilli -= 1
}
- try {
- val zoneId = tz match {
- case None => timeZoneId
- case Some("+") => ZoneOffset.ofHoursMinutes(segments(7), segments(8))
- case Some("-") => ZoneOffset.ofHoursMinutes(-segments(7), -segments(8))
- case Some(zoneName: String) => getZoneId(zoneName.trim)
- }
- val nanoseconds = MICROSECONDS.toNanos(segments(6))
- val localTime = LocalTime.of(segments(3), segments(4), segments(5),
nanoseconds.toInt)
- val localDate = if (justTime) {
- LocalDate.now(zoneId)
- } else {
- LocalDate.of(segments(0), segments(1), segments(2))
- }
- val localDateTime = LocalDateTime.of(localDate, localTime)
- val zonedDateTime = ZonedDateTime.of(localDateTime, zoneId)
- val instant = Instant.from(zonedDateTime)
- Some(instantToMicros(instant))
- } catch {
- case NonFatal(_) => None
+ val zoneId = tz match {
+ case None => timeZoneId
+ case Some("+") => ZoneOffset.ofHoursMinutes(segments(7), segments(8))
+ case Some("-") => ZoneOffset.ofHoursMinutes(-segments(7), -segments(8))
+ case Some(zoneName: String) => getZoneId(zoneName.trim)
+ }
+ val nanoseconds = MICROSECONDS.toNanos(segments(6))
+ val localTime = LocalTime.of(segments(3), segments(4), segments(5),
nanoseconds.toInt)
+ val localDate = if (justTime) {
+ LocalDate.now(zoneId)
+ } else {
+ LocalDate.of(segments(0), segments(1), segments(2))
}
+ val localDateTime = LocalDateTime.of(localDate, localTime)
+ val zonedDateTime = ZonedDateTime.of(localDateTime, zoneId)
+ val instant = Instant.from(zonedDateTime)
+ Some(instantToMicros(instant))
+ } catch {
+ case NonFatal(_) => None
}
+
Review comment:
can you remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
