ekoifman commented on a change in pull request #32872:
URL: https://github.com/apache/spark/pull/32872#discussion_r669006682
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/CustomShuffleReaderExec.scala
##########
@@ -87,8 +87,15 @@ case class CustomShuffleReaderExec private(
Iterator(desc)
}
- def hasCoalescedPartition: Boolean =
- partitionSpecs.exists(_.isInstanceOf[CoalescedPartitionSpec])
+ /**
+ * Returns true iff some non-empty partitions were combined
+ */
+ def hasCoalescedPartition: Boolean = {
+ partitionSpecs.exists {
+ case s: CoalescedPartitionSpec => s.endReducerIndex -
s.startReducerIndex > 1
Review comment:
The intent of this PR is to have`hasCoalesedPartitions` only return true
if some were combined - to avoid reporting "coalesced" when partition spec
looks something like `CoalescePartitionSpec(0, 1), CoalescePartitionSpec(1, 2)`
Even if `CoalescePartitionSpec(0, 0, 0)` is possible, it's not combining
anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
