dongjoon-hyun commented on a change in pull request #33329:
URL: https://github.com/apache/spark/pull/33329#discussion_r669153013
##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -2598,11 +2598,16 @@ private[spark] object Utils extends Logging {
* Support push based shuffle with multiple app attempts
*/
def isPushBasedShuffleEnabled(conf: SparkConf): Boolean = {
- conf.get(PUSH_BASED_SHUFFLE_ENABLED) &&
+ val isPushBasedShuffleEnabled = conf.get(PUSH_BASED_SHUFFLE_ENABLED) &&
(conf.get(IS_TESTING).getOrElse(false) ||
(conf.get(SHUFFLE_SERVICE_ENABLED) &&
conf.get(SparkLauncher.SPARK_MASTER, null) == "yarn" &&
getYarnMaxAttempts(conf) == 1))
+ if (isPushBasedShuffleEnabled && !conf.get(IS_TESTING).getOrElse(false)) {
+ // TODO: Remove this once push-based shuffle is fully supported.
Review comment:
This `TODO` is not required because `branch-3.2` will never allow it in
the future if we didn't deliver at 3.2.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
