dongjoon-hyun commented on a change in pull request #33330:
URL: https://github.com/apache/spark/pull/33330#discussion_r669196510
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetColumnIndexSuite.scala
##########
@@ -31,24 +31,25 @@ class ParquetColumnIndexSuite extends QueryTest with
ParquetTest with SharedSpar
* |-------|-----|-----|---|---|---|---|---|
* col_2 400 300 200 200 200 200 200 200
*/
- def checkUnalignedPages(actions: (DataFrame => DataFrame)*): Unit = {
+ def checkUnalignedPages(df: DataFrame)(actions: (DataFrame => DataFrame)*):
Unit = {
withTempPath(file => {
- val ds = spark.range(0, 2000).map(i => (i, i + ":" + "o" * (i /
100).toInt))
- ds.coalesce(1)
+ df.coalesce(1)
.write
.option("parquet.page.size", "4096")
+ .option("parquet.enable.dictionary", "false")
Review comment:
In terms of the test coverage, we had better test both cases, `true` and
`false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
