Ngone51 commented on pull request #33116: URL: https://github.com/apache/spark/pull/33116#issuecomment-879544440
> My only concern with this approach is if some other metrics reporter (besides YarnShuffleService) may try to use these custom timers as if they still had nanosecond units. I'm not familiar enough with how the metrics are used in the non-YARN context to know if this will be an issue, so input is welcomed here. Ideally, one should learn the usage before using the timer. That being said, I think we can force the `TimerWithMillisecondSnapshots` to receive a time-unit parameter to indicate which time-unit it exposes. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
