zhouyejoe commented on pull request #33078: URL: https://github.com/apache/spark/pull/33078#issuecomment-879626748
> I don't see any UTs added for all the issues that were identified with concurrency. Is there a problem in adding UTs for these cases? I added one unit test where the registerExecutor happens between multiple PushBlockStream.onData callbacks. What additional unit tests should we add to test the concurrency? Public APIs are bundled with validateAndGetAppShuffleInfo(appId) and it should be safe here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
