cloud-fan commented on a change in pull request #33284:
URL: https://github.com/apache/spark/pull/33284#discussion_r669488965
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/DecorrelateInnerQuery.scala
##########
@@ -154,6 +154,23 @@ object DecorrelateInnerQuery extends PredicateHelper {
expressions.map(replaceOuterReference(_, outerReferenceMap))
}
+ /**
+ * Replace all outer references in the given named expressions and keep the
output
+ * attributes unchanged.
+ */
+ private def replaceOuterInNamedExpressions(
+ expressions: Seq[NamedExpression],
+ outerReferenceMap: Map[Attribute, Attribute]): Seq[NamedExpression] = {
+ expressions.map { expr =>
+ val newExpr = replaceOuterReference(expr, outerReferenceMap)
+ if (!newExpr.toAttribute.semanticEquals(expr.toAttribute)) {
Review comment:
how can this happen? `OuterReference` is not a `NamedExpression` and
there must be an alias above it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
