sunchao opened a new pull request #33348:
URL: https://github.com/apache/spark/pull/33348
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
In `CatalogFileIndex.filterPartitions`, check the config
`spark.sql.hive.metastorePartitionPruning` and don't pushdown predicates to
remote HMS if it is false. Instead, fallback to the `listPartitions` API and do
the filtering on the client side.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Currently the config `spark.sql.hive.metastorePartitionPruning` is only
effective for Hive tables, and for non-Hive tables we'd always use the
`listPartitionsByFilter` API from HMS client. On the other hand, by default all
data source tables also manage their partitions through HMS, when the config
`spark.sql.hive.manageFilesourcePartitions` is turned on. Therefore, it seems
reasonable to extend the above config for non-Hive tables as well.
In certain cases the remote HMS service could throw exceptions when using
the `listPartitionsByFilter` API, which, on the Spark side, is unrecoverable at
the current state. Therefore it would be better to allow users to disable the
API by using the above config.
For instance, HMS only allow pushdown date column when direct SQL is used
instead of JDO for interacting with the underlying RDBMS, and will throw
exception otherwise. Even though the Spark Hive client will attempt to recover
itself when the exception happens, it only does so when the config
`hive.metastore.try.direct.sql` from remote HMS is `false`. There could be
cases where the value of `hive.metastore.try.direct.sql` is true but remote HMS
still throws exception.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes now the config `spark.sql.hive.metastorePartitionPruning` is extended
for non-Hive tables which use HMS to manage their partition metadata.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
Added a new unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
