eejbyfeldt commented on pull request #33205: URL: https://github.com/apache/spark/pull/33205#issuecomment-880608127
> hi @eejbyfeldt please feel free to drive this forward. Thank you for the work. Happy if you'd like to make a patch here :) > On backward-compat, i think one problem is the historical data that was written with `List[ValueClass]` will have wrapped schema. This has been working and we likely won't get good grasp from stackoverflow or mailing list. I pushed a commit here (Since I think I am not allow to push to your branch): https://github.com/eejbyfeldt/spark/commit/cbbe05e0c1c2b942e6337e62a03991ee7fa95d26 it should be based on this branch therefore you can just cherry-pick it to this branch. Yeah, thinking about it I agree that it better to be backwards compatible. Then this change can be seen as a bug fix for "nested value classes" and will not break an existing code, which should be a much "safer" change to do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
