holdenk commented on a change in pull request #33270:
URL: https://github.com/apache/spark/pull/33270#discussion_r670546421
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
##########
@@ -181,7 +184,51 @@ private[spark] class KubernetesClusterSchedulerBackend(
super.getExecutorIds()
}
+ private def labelLowPriorityExecs(execIds: Seq[String]) = {
Review comment:
Good point. We could say `labelExecsForDecommissioning`?
##########
File path:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackendSuite.scala
##########
@@ -166,26 +168,71 @@ class KubernetesClusterSchedulerBackendSuite extends
SparkFunSuite with BeforeAn
test("Kill executors") {
schedulerBackendUnderTest.start()
+
+ val operation =
mock(classOf[io.fabric8.kubernetes.client.dsl.NonNamespaceOperation[
+ io.fabric8.kubernetes.api.model.Pod,
+ io.fabric8.kubernetes.api.model.PodList,
+
io.fabric8.kubernetes.client.dsl.PodResource[io.fabric8.kubernetes.api.model.Pod]]])
Review comment:
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
