cloud-fan commented on a change in pull request #33347:
URL: https://github.com/apache/spark/pull/33347#discussion_r670614331
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/parquet/ParquetScanBuilder.scala
##########
@@ -49,10 +49,22 @@ case class ParquetScanBuilder(
val pushDownStringStartWith = sqlConf.parquetFilterPushDownStringStartWith
val pushDownInFilterThreshold =
sqlConf.parquetFilterPushDownInFilterThreshold
val isCaseSensitive = sqlConf.caseSensitiveAnalysis
+ val parquetOptions = new ParquetOptions(caseSensitiveMap,
sparkSession.sessionState.conf)
+ val datetimeRebaseMode = DataSourceUtils.datetimeRebaseMode(
+ // Metadata of parquet files (spark version, for instance) is not
available at the moment
+ _ => null,
+ parquetOptions.datetimeRebaseModeInRead)
val parquetSchema =
new
SparkToParquetSchemaConverter(sparkSession.sessionState.conf).convert(readDataSchema())
- val parquetFilters = new ParquetFilters(parquetSchema, pushDownDate,
pushDownTimestamp,
- pushDownDecimal, pushDownStringStartWith, pushDownInFilterThreshold,
isCaseSensitive)
+ val parquetFilters = new ParquetFilters(
+ parquetSchema,
+ pushDownDate,
+ pushDownTimestamp,
+ pushDownDecimal,
+ pushDownStringStartWith,
+ pushDownInFilterThreshold,
+ isCaseSensitive,
+ datetimeRebaseMode)
parquetFilters.convertibleFilters(this.filters).toArray
Review comment:
We create `ParquetFilters` here only to check which filters are
convertible, and rebase mode doesn't matter.
Shall we use pass `datetimeRebaseMode` as `CORRECTED` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
